OkI have a stock base 2 door. Someone is giving me a set of shocks and springs off a stock unlimited. They are 17s and 58s whatever that means. Please let me know. Thanks

 

"17" and "58" are the spring numbers (actually, the last two digits of the spring numbers). They are stronger springs than stock Sport/X springs. A 2-door Sport/X will sit a bit taller, carry weight better, and ride better on them.

The shocks will also work fine. I ran the same setup on my Sport for a year. It was a big improvement.

 

Crawl under your jeep and look at the tags on your front and rear coil springs. The last two digits are what you are looking for. Weakest/softest springs are 12, strongest are 19 for front. In the rear I forget what the lowest are, but the highest are 60(the higher the better). I put a set of Unlimited Ruby springs on my two door last weekend. I started off with 12 Front left 13 Front right and 55 Rear. The jku ruby springs were 18/59. After installation I got a slight lift and it rides much better in my opinion. If your stock coils are low in digits it is worth upgrading.
Before/After

 

Can I leave the shocks. The person giving me the springs has the shocks as well but they are not rubi.

 

I got a set of rubi shocks with my springs because I was unsure. But when I got the stock shocks off I compared them to the rubi's and they were the same length. So I think you will be ok. And if you do decide you wanna upgrade to rubi shocks, you can always find a good used set on ebay for cheap.

 

Depends on what his shocks are. The stock Sport/X shock is not that much of a shock so if you have the opportunity to upgrade while you have it apart, go for it. If his shocks are the same as yours and you don't want to invest in new ones, then use the freshest set - assuming none are leaking.

Rubi shocks and Sport/X shocks are the same length, but the body of a Rubi shock is a bit larger diameter.